feat(client): support local bind for HttpConnector #1500
Conversation
kw217
force-pushed
the
1498-add-local-bind
branch
2 times, most recently
from
95155c4 to
d433c2e
Compare
|
I'm not sure what caused the build timeout; I don't think it's related to my code. |
| /// | ||
| /// Default is `None`. | ||
| #[inline] | ||
| pub fn set_local_address(&mut self, addr: Option<IpAddr>) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
It's normally called the local address; see bind(2) at https://linux.die.net/man/2/bind and http://pubs.opengroup.org/onlinepubs/009695399/functions/bind.html . Normally bind takes a SockAddr, but for this specific case of binding-before-connecting, it's vanishingly rare that you want to specify the port as well as the IP, which is why I have specified IpAddr. But it's still an address.
examples/bound_client.rs
Outdated
| @@ -0,0 +1,56 @@ | |||
| #![deny(warnings)] | |||
There was a problem hiding this comment.
I think my personal preference here would be to not include an entire example file, as it means another thing to adjust when changes are required. We don't have an example for every combination of configuration options...
There was a problem hiding this comment.
No problem - it was just there to show what it would look like. I've removed it now.
kw217
force-pushed
the
1498-add-local-bind
branch
2 times, most recently
from
82c4bea to
a80471a
Compare
|
Woops, test failures are because the |
Add `set_local_address` to the `HttpConnector`. This configures the client to bind the socket to a local address of the host before it connects to the destination. This is useful on hosts which have multiple network interfaces, to ensure the request is issued over a specific interface. Closes hyperium#1498
|
Right, sorry about that. Fixed now - back to the same timeout error you said not to worry about. |
|
Thanks so much! |
|
Thank you! |
Add
set_local_addressto theHttpConnector.This configures the client to bind the socket to a local address of
the host before it connects to the destination. This is useful on
hosts which have multiple network interfaces, to ensure the request is
issued over a specific interface.
Includes an example to show how it is used and regression-check the API (copied from the existing client example). Please let me know if I should be adding any tests, and if so where.
Closes #1498